[OZAPRS] Xastir maps... again
Dave Horsfall
dave at horsfall.org
Wed Feb 7 21:57:44 EST 2007
On Tue, 6 Feb 2007, Ron Perry top-posted:
> Dave,
> With respect, if you can't help then please stop just criticising.
Since I seem to be the only one around here who's actually paid to write
Perl, here's some free advice:
[ You'll have to sort out Ron's top-posting for yourself ]
> > > The "identify" routine from imagemagick is called in this line
> > > > $string = `identify -ping $try_filename 2>/dev/null`;
> >
> > Whoever wrote that POS ought to be taken out the back and shot.
That statement will execute "identify" wherever it happens to be in your
$PATH, assuming that it exists at all. Think of Grecian equines...
It will throw away any error messages that might actually provide a hint
as to what went wrong.
Is $filename made safe? I.e. untainted?
And I have a problem with ImageMagick hijacking "identify".
-- Dave
_______________________________________________
Ozaprs mailing list
Ozaprs at aprs.net.au
http://aprs.net.au/mailman/listinfo/ozaprs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://second.aprs.net.au/pipermail/ozaprs/attachments/20070207/10c634e2/attachment.htm
More information about the Ozaprs
mailing list